fix(editorconfig): do not set 'endofline'

Problem:
  'endofline' can be used to detect if a file ends of <EOL>, however
  editorconfig can break this.

Solution:
  Set 'endofline' during BufWritePre

Fixes: #24869
This commit is contained in:
Lewis Russell 2023-08-25 12:23:05 +01:00 committed by Lewis Russell
parent 63802a1dbf
commit abb8c2c453
2 changed files with 16 additions and 3 deletions

View File

@ -112,7 +112,20 @@ end
function M.properties.insert_final_newline(bufnr, val)
assert(val == 'true' or val == 'false', 'insert_final_newline must be either "true" or "false"')
vim.bo[bufnr].fixendofline = val == 'true'
vim.bo[bufnr].endofline = val == 'true'
-- 'endofline' can be read to detect if the file contains a final newline,
-- so only change 'endofline' right before writing the file
local endofline = val == 'true'
if vim.bo[bufnr].endofline ~= endofline then
vim.api.nvim_create_autocmd('BufWritePre', {
group = 'editorconfig',
buffer = bufnr,
once = true,
callback = function()
vim.bo[bufnr].endofline = endofline
end,
})
end
end
--- Modified version of |glob2regpat()| that does not match path separators on *.

View File

@ -160,8 +160,8 @@ describe('editorconfig', function()
end)
it('sets newline options', function()
test_case('with_newline.txt', { fixendofline = true, endofline = true })
test_case('without_newline.txt', { fixendofline = false, endofline = false })
test_case('with_newline.txt', { fixendofline = true })
test_case('without_newline.txt', { fixendofline = false })
end)
it('respects trim_trailing_whitespace', function()