From 8206954a67b96702619ba70d011b454696a608ef Mon Sep 17 00:00:00 2001 From: dundargoc <33953936+dundargoc@users.noreply.github.com> Date: Sun, 28 May 2023 15:28:53 +0200 Subject: [PATCH] build: remove LOG_DEBUG option Its usecase is too specific to warrant an option. The same effect can be achieved by passing `-DCMAKE_C_FLAGS=-DNVIM_LOG_DEBUG` in the command line when building neovim. --- CMakeLists.txt | 1 - src/nvim/CMakeLists.txt | 3 --- 2 files changed, 4 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 4e57d6905f..76930e0e6c 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -149,7 +149,6 @@ endif() option(LOG_LIST_ACTIONS "Add list actions logging" OFF) option(ENABLE_ASAN_UBSAN "Enable Clang address & undefined behavior sanitizer for nvim binary." OFF) -option(LOG_DEBUG "Enable debug log messages even in a release build" OFF) option(ENABLE_MSAN "Enable Clang memory sanitizer for nvim binary." OFF) option(ENABLE_TSAN "Enable Clang thread sanitizer for nvim binary." OFF) diff --git a/src/nvim/CMakeLists.txt b/src/nvim/CMakeLists.txt index 47f32abc07..222b283a5d 100644 --- a/src/nvim/CMakeLists.txt +++ b/src/nvim/CMakeLists.txt @@ -394,9 +394,6 @@ endif() if($ENV{CI}) # Don't debug log on CI, it gets too verbose in the main build log. # TODO(bfredl): debug log level also exposes some errors with EXITFREE in ASAN build. - set(LOG_DEBUG FALSE) -elseif(LOG_DEBUG) - target_compile_definitions(nvim PRIVATE NVIM_LOG_DEBUG) else() # Minimize logging for release-type builds. target_compile_definitions(nvim PRIVATE $<$:NVIM_LOG_DEBUG>)