wyj/neovim
1
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2024-09-17 20:58:20 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(messages): avoid passing negative length to strnlen() (#28753)

Browse Source 
Problem:  Compiler warning when building Nvim in Release mode:

    In function ‘msg_puts_display’,
        inlined from ‘disp_sb_line’ at **/src/nvim/message.c:2647:5:
    **/src/nvim/message.c:2165:18: warning: ‘strnlen’ specified bound 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Wstringop-overread]
     2165 |     size_t len = strnlen(str, (size_t)maxlen);
          |                  ^

Solution: Use strlen() when maxlen is negative.
This commit is contained in:
zeertzjq 2024-05-15 19:38:50 +08:00 committed by GitHub
parent 14a5813c20
commit 61a0aa6c51
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/nvim/message.c
View File

@ -2162,7 +2162,7 @@ static void msg_puts_display(const char *str, int maxlen, int attr, int recurse)
msg_ext_last_attr = attr; msg_ext_last_attr = attr;
} }
// Concat pieces with the same highlight // Concat pieces with the same highlight
size_t len = strnlen(str, (size_t)maxlen); size_t len = maxlen < 0 ? strlen(str) : strnlen(str, (size_t)maxlen);
ga_concat_len(&msg_ext_last_chunk, str, len); ga_concat_len(&msg_ext_last_chunk, str, len);
msg_ext_cur_len += len; msg_ext_cur_len += len;
return; return;